Allow gRPC calls with larger query responses #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljoss17
added
I: rpc
romac
requested changes
May 15, 2023
crates/relayer/src/config.rs
Outdated
| @@ -472,6 +473,8 @@ pub struct ChainConfig { | |||
| pub max_msg_num: MaxMsgNum, | |||
| #[serde(default)] | |||
| pub max_tx_size: MaxTxSize, | |||
| #[serde(default)] | |||
| pub max_grpc_decoding_size: Option<Byte>, | |||
There was a problem hiding this comment.
Let's set the default value here so that we avoid the if/else at each use site.
romac
reviewed
May 15, 2023
crates/relayer/src/chain/cosmos.rs
Outdated
| @@ -120,6 +122,8 @@ pub mod types; | |||
| pub mod version; | |||
| pub mod wait; | |||
|
|
|||
| pub const DEFAULT_GRPC_MAX_MESSAGE_LENGTH: u64 = n_mib_bytes(32); | |||
There was a problem hiding this comment.
Let's remove this and use a default straight in the config struct to avoid the if/else's below
romac
reviewed
May 15, 2023
| { status: GrpcStatus } | ||
| |e| { format!("gRPC call failed with status: {0}", e.status) }, | ||
| { status: GrpcStatus, query: String } | ||
| |e| { format!("gRPC call `{}` failed with status: {1}", e.query, e.status) }, |
romac
approved these changes
May 16, 2023
romac
pushed a commit
that referenced
this pull request
May 16, 2023
* Adds a new undocumented configuration `max_grpc_decoding_size` which can be used to specify a new decoding message size upper limit * Updates the gRPC clients decoding message size limit with `max_decoding_message_size()`. If the the `max_grpc_decoding_size` is not configured, sets the limit to `32 MiB`. * Adds the name of the failed query to the `GrpcStatus` error output message --- * Increase gRPC max decoding message size using default value or configured value * Remove const value for max_grpc_decoding_size and use default instead
7 tasks
pratikbin
pushed a commit
to pratikbin/hermes
that referenced
this pull request
May 24, 2023
* Adds a new undocumented configuration `max_grpc_decoding_size` which can be used to specify a new decoding message size upper limit * Updates the gRPC clients decoding message size limit with `max_decoding_message_size()`. If the the `max_grpc_decoding_size` is not configured, sets the limit to `32 MiB`. * Adds the name of the failed query to the `GrpcStatus` error output message --- * Increase gRPC max decoding message size using default value or configured value * Remove const value for max_grpc_decoding_size and use default instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3334
Description
This PR has the following updates:
max_grpc_decoding_sizewhich can be used to specify a new decoding message size upper limitmax_decoding_message_size(). If the themax_grpc_decoding_sizeis not configured, sets the limit to32 MiB.GrpcStatuserror output messagePR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.